webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc

diff --git a/webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc b/webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc

index 52aa70b3f431c9662b1f98c62ed31cedbc5ba54b..869ea9f5aef5b974cdb5bd92c356eda4acd31616 100644

--- a/webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc

+++ b/webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc

@@ -355,12 +355,13 @@ void WebPluginDelegateImpl::WindowlessPaint(cairo_t* context,

// "real" means as seen by Chrome

// "apparent" means as seen by the plugin.

- gfx::Rect draw_rect = window_rect_.Intersect(damage_rect);

+ gfx::Rect draw_rect = window_rect_;

+ draw_rect.Intersect(damage_rect);

// clip_rect_ is relative to the plugin

gfx::Rect clip_rect_window = clip_rect_;

clip_rect_window.Offset(window_rect_.x(), window_rect_.y());

- draw_rect = draw_rect.Intersect(clip_rect_window);

+ draw_rect.Intersect(clip_rect_window);

// These offsets represent by how much the view is shifted to accomodate

// Flash (the coordinates of X relative to O in the diagram above).

« no previous file with comments | « ui/views/win/hwnd_message_handler.cc ('k') | webkit/plugins/npapi/webplugin_delegate_impl_mac.mm » ('j') | no next file with comments »