ui/views/widget/root_view.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/root_view.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/root_view.cc

diff --git a/ui/views/widget/root_view.cc b/ui/views/widget/root_view.cc

index 2db6cb14e13875ca7e933cbbcdb9e20a951a18d8..ec6dc50ced2a08e778497b1a818a2db6170a7be0 100644

--- a/ui/views/widget/root_view.cc

+++ b/ui/views/widget/root_view.cc

@@ -191,7 +191,8 @@ void RootView::SchedulePaintInRect(const gfx::Rect& rect) {

layer()->SchedulePaint(rect);

} else {

gfx::Rect xrect = ConvertRectToParent(rect);

- gfx::Rect invalid_rect = GetLocalBounds().Intersect(xrect);

+ gfx::Rect invalid_rect = GetLocalBounds();

+ invalid_rect.Intersect(xrect);

if (!invalid_rect.IsEmpty())

widget_->SchedulePaintInRect(invalid_rect);

}

« no previous file with comments | « ui/views/widget/native_widget_aura.cc ('k') | ui/views/widget/tooltip_manager_win.cc » ('j') | no next file with comments »