ui/views/view.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/view.cc

diff --git a/ui/views/view.cc b/ui/views/view.cc

index 7fc0fe6f181e0ff51770da68ecce8eb757bfd1ee..d2830f7f239f3016c8dfbec08bf8ba0b1ec76d61 100644

--- a/ui/views/view.cc

+++ b/ui/views/view.cc

@@ -336,7 +336,7 @@ gfx::Rect View::GetVisibleBounds() const {

const View* ancestor = view->parent_;

if (ancestor != NULL) {

ancestor_bounds.SetRect(0, 0, ancestor->width(), ancestor->height());

- vis_bounds = vis_bounds.Intersect(ancestor_bounds);

+ vis_bounds.Intersect(ancestor_bounds);

} else if (!view->GetWidget()) {

// If the view has no Widget, we're not visible. Return an empty rect.

return gfx::Rect();

« no previous file with comments | « ui/views/layout/box_layout.cc ('k') | ui/views/view_unittest.cc » ('j') | no next file with comments »