content/common/gpu/image_transport_surface.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/image_transport_surface.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/image_transport_surface.cc

diff --git a/content/common/gpu/image_transport_surface.cc b/content/common/gpu/image_transport_surface.cc

index 8c1241d6d5e0e413a8cdd212e0c620a35d275d72..dce01a234876b204cbd5f8ed3ccb2e139855893a 100644

--- a/content/common/gpu/image_transport_surface.cc

+++ b/content/common/gpu/image_transport_surface.cc

@@ -32,7 +32,8 @@ void ImageTransportSurface::GetRegionsToCopy(

const gfx::Rect& previous_damage_rect,

const gfx::Rect& new_damage_rect,

std::vector<gfx::Rect>* regions) {

- gfx::Rect intersection = previous_damage_rect.Intersect(new_damage_rect);

+ gfx::Rect intersection = previous_damage_rect;

+ intersection.Intersect(new_damage_rect);

if (intersection.IsEmpty()) {

regions->push_back(previous_damage_rect);

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_win.cc ('k') | content/plugin/webplugin_proxy.cc » ('j') | no next file with comments »