Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5102)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: cc/ fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc
index 67eae60e55d76511d0bbc07f9fb0eb087d53524d..72ee51ca135c76cae9423dd3df1297fa26e66460 100644
--- a/chrome/browser/ui/views/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar_view.cc
@@ -444,7 +444,8 @@ void ToolbarView::LayoutForSearch() {
// Note that parent of |location_bar_container_| i.e. BrowserView can't clip
// its children, else it loses the 3D shadows.
gfx::Rect parent_rect = location_bar_container_->parent()->GetLocalBounds();
- gfx::Rect intersect_rect = parent_rect.Intersect(location_container_bounds);
+ gfx::Rect intersect_rect = parent_rect;
+ intersect_rect.Intersect(location_container_bounds);
// If the two bounds don't intersect, set bounds of |location_bar_container_|
// to 0.
location_bar_container_->SetBoundsRect(intersect_rect);
« no previous file with comments | « chrome/browser/ui/views/notifications/balloon_view_views.cc ('k') | chrome/browser/ui/window_sizer/window_sizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698