chrome/browser/instant/instant_controller.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_controller.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/instant/instant_controller.cc

diff --git a/chrome/browser/instant/instant_controller.cc b/chrome/browser/instant/instant_controller.cc

index e4a3a4e1da4993b15434f79858678cea31809b61..a05c8edef765a65b2820342652d1dac10825ed85 100644

--- a/chrome/browser/instant/instant_controller.cc

+++ b/chrome/browser/instant/instant_controller.cc

@@ -751,7 +751,8 @@ void InstantController::SendBoundsToPage() {

last_omnibox_bounds_ = omnibox_bounds_;

gfx::Rect preview_bounds = delegate_->GetInstantBounds();

- gfx::Rect intersection = omnibox_bounds_.Intersect(preview_bounds);

+ gfx::Rect intersection = omnibox_bounds_;

+ intersection.Intersect(preview_bounds);

// Translate into window coordinates.

if (!intersection.IsEmpty()) {

« no previous file with comments | « cc/software_renderer.cc ('k') | chrome/browser/notifications/balloon_collection_impl.cc » ('j') | no next file with comments »