ash/launcher/launcher_view.cc - Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/launcher/launcher_view.cc

Issue 11110004: Make gfx::Rect class operations consistently mutate the class they are called on. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: cc/ fixes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/launcher/launcher_view.cc

diff --git a/ash/launcher/launcher_view.cc b/ash/launcher/launcher_view.cc

index a3c2fe79aced7c97698bf1b79aec29b8538fad9a..c5044ad5c9a57078f92217dfa6aad4decff7caef 100644

--- a/ash/launcher/launcher_view.cc

+++ b/ash/launcher/launcher_view.cc

@@ -705,7 +705,7 @@ bool LauncherView::ShouldHideTooltip(const gfx::Point& cursor_location) {

continue;

gfx::Rect child_bounds = child->GetMirroredBounds();

- active_bounds = active_bounds.Union(child_bounds);

+ active_bounds.Union(child_bounds);

}

return !active_bounds.Contains(cursor_location);

« no previous file with comments | « ash/drag_drop/drag_drop_controller_unittest.cc ('k') | ash/launcher/launcher_view_unittest.cc » ('j') | no next file with comments »