Make gfx::Rect class operations consistently mutate the class they are called on.

content/renderer/browser_plugin/browser_plugin_backing_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_backing_store.h"
 
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/rect_conversions.h"
 #include "ui/gfx/size_conversions.h"
@@ skipping 19 matching lines @@
 BrowserPluginBackingStore::~BrowserPluginBackingStore() {
 }
 
 void BrowserPluginBackingStore::PaintToBackingStore(
     const gfx::Rect& bitmap_rect,
     const std::vector<gfx::Rect>& copy_rects,
     TransportDIB* dib) {
   if (bitmap_rect.IsEmpty())
     return;
 
-  gfx::Rect pixel_bitmap_rect =
-      gfx::ToEnclosingRect(bitmap_rect.Scale(scale_factor_));
+  gfx::RectF scaled_bitmap_rect = bitmap_rect;
+  scaled_bitmap_rect.Scale(scale_factor_);
+  gfx::Rect pixel_bitmap_rect = gfx::ToEnclosingRect(scaled_bitmap_rect);
 
   const int width = pixel_bitmap_rect.width();
   const int height = pixel_bitmap_rect.height();
 
   if (width <= 0 || width > kMaxSize ||
       height <= 0 || height > kMaxSize)
     return;
 
   if (!dib)
     return;
 
   SkPaint copy_paint;
   copy_paint.setXfermodeMode(SkXfermode::kSrc_Mode);
 
   SkBitmap sk_bitmap;
   sk_bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, height);
   sk_bitmap.setPixels(dib->memory());
   for (size_t i = 0; i < copy_rects.size(); i++) {
-    const gfx::Rect& pixel_copy_rect =
-        gfx::ToEnclosingRect(copy_rects[i].Scale(scale_factor_));
+    gfx::RectF scaled_copy_rect = copy_rects[i];
+    scaled_copy_rect.Scale(scale_factor_);
+    const gfx::Rect& pixel_copy_rect = gfx::ToEnclosingRect(scaled_copy_rect);
     int x = pixel_copy_rect.x() - pixel_bitmap_rect.x();
     int y = pixel_copy_rect.y() - pixel_bitmap_rect.y();
     SkIRect srcrect = SkIRect::MakeXYWH(x, y,
         pixel_copy_rect.width(),
         pixel_copy_rect.height());
 
     SkRect dstrect = SkRect::MakeXYWH(
         SkIntToScalar(pixel_copy_rect.x()),
         SkIntToScalar(pixel_copy_rect.y()),
         SkIntToScalar(pixel_copy_rect.width()),
         SkIntToScalar(pixel_copy_rect.height()));
     canvas_.get()->drawBitmapRect(sk_bitmap, &srcrect, dstrect, &copy_paint);
   }
 }
 
 void BrowserPluginBackingStore::ScrollBackingStore(
     int dx,
     int dy,
     const gfx::Rect& clip_rect,
     const gfx::Size& view_size) {
-  gfx::Rect pixel_rect = gfx::ToEnclosingRect(clip_rect.Scale(scale_factor_));
+  gfx::RectF scaled_clip_rect = clip_rect;
+  scaled_clip_rect.Scale(scale_factor_);
+  gfx::Rect pixel_rect = gfx::ToEnclosingRect(scaled_clip_rect);
   int pixel_dx = dx * scale_factor_;
   int pixel_dy = dy * scale_factor_;
 
   int x = std::min(pixel_rect.x(), pixel_rect.x() - pixel_dx);
   int y = std::min(pixel_rect.y(), pixel_rect.y() - pixel_dy);
   int w = pixel_rect.width() + abs(pixel_dx);
   int h = pixel_rect.height() + abs(pixel_dy);
   SkIRect rect = SkIRect::MakeXYWH(x, y, w, h);
   bitmap_.scrollRect(&rect, pixel_dx, pixel_dy);
 }
 
 }  // namespace content