Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1110993002: Revert of removing equality / compute invariant loops from GrGeometryProcessors (Closed)

Created:
5 years, 7 months ago by joshualitt
Modified:
5 years, 7 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of removing equality / compute invariant loops from GrGeometryProcessors (patchset #2 id:20001 of https://codereview.chromium.org/1111603004/) Reason for revert: breaks gl programs Original issue's description: > removing equality / compute invariant loops from GrGeometryProcessors > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ef292a0901205b9785a30daae2c036aa34a970ca TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/50cb76b2bb0ffa607a1409f77be0ae7d64e31436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -45 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 3 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 7 chunks +36 lines, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 2 chunks +52 lines, -11 lines 0 comments Download
A src/gpu/GrGeometryProcessor.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +60 lines, -0 lines 0 comments Download
M src/gpu/GrTestBatch.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +27 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +50 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 2 chunks +13 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 4 chunks +44 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 8 chunks +64 lines, -0 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 5 chunks +36 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 10 chunks +76 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of removing equality / compute invariant loops from GrGeometryProcessors
5 years, 7 months ago (2015-04-28 16:16:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110993002/1
5 years, 7 months ago (2015-04-28 16:16:55 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:17:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/50cb76b2bb0ffa607a1409f77be0ae7d64e31436

Powered by Google App Engine
This is Rietveld 408576698