Issue 1110963003: Use "define" instead of "const" for natives macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110963003: Use "define" instead of "const" for natives macros (Closed)

Created:
5 years, 7 months ago by domenic

Modified:
5 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit), Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Use "define" instead of "const" for natives macros The use of "const" prevented the actual JavaScript const keyword from functioning as intended. R=jochen@chromium.org,yangguo@chromium.org BUG= Committed: https://crrev.com/f39707cd964b27b11a996d72c898b0b6dbc0ab4a Cr-Commit-Position: refs/heads/master@{#28111}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -111 lines)			Patch
M	src/macros.py	View	6 chunks	+69 lines, -69 lines	0 comments	Download
M	src/third_party/fdlibm/fdlibm.js	View	10 chunks	+40 lines, -40 lines	0 comments	Download
M	tools/js2c.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110963003/1

5 years, 7 months ago (2015-04-28 14:21:48 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 14:58:31 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f39707cd964b27b11a996d72c898b0b6dbc0ab4a
Cr-Commit-Position: refs/heads/master@{#28111}