Added switch to disable specified GL extensions.

ui/gl/gl_gl_api_implementation.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_gl_api_implementation.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
+#include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_state_restorer.h"
 #include "ui/gl/gl_surface.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/gl/gl_version_info.h"
 
 namespace gfx {
 
@@ skipping 281 matching lines @@
   g_real_gl->Initialize(&g_driver_gl);
   g_gl = g_real_gl;
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableGPUServiceTracing)) {
     g_gl = g_trace_gl;
   }
   SetGLToRealGLApi();
 }
 
 GLApi* GetCurrentGLApi() {
-  return g_current_gl_context_tls->Get();
+  return g_current_gl_context_tls ? g_current_gl_context_tls->Get() : nullptr;
 }
 
 void SetGLApi(GLApi* api) {
   g_current_gl_context_tls->Set(api);
 }
 
 void SetGLToRealGLApi() {
   SetGLApi(g_gl);
 }
 
@@ skipping 74 matching lines @@
   driver_ = driver;
 }
 
 RealGLApi::RealGLApi() {
 }
 
 RealGLApi::~RealGLApi() {
 }
 
 void RealGLApi::Initialize(DriverGL* driver) {
+  InitializeWithCommandLine(driver, base::CommandLine::ForCurrentProcess());
+}
+
+void RealGLApi::InitializeWithCommandLine(DriverGL* driver,
+                                          base::CommandLine* command_line) {
+  DCHECK(command_line);
   InitializeBase(driver);
+
+  filtered_exts_.clear();
+  filtered_exts_str_.clear();

[no sievers, 2015/05/01 21:55:00]

Is this because of some unittests?
Can we clear this from ClearGLBindings() instead and DCHECK() here that they are
empty?

[David Yen, 2015/05/01 22:34:38]

These are per instance of the class though, ClearGLBindings() just deletes the
global instance of RealGLApi so it's not relevant.

I suppose normally it would be cleared in a "Destroy" function of some sort. If
it bothers you I can just re-instantiate the class in the unit tests.

+
+  const std::string disabled_extensions = command_line->GetSwitchValueASCII(
+      switches::kDisableGLExtensions);
+  if (!disabled_extensions.empty()) {
+    std::vector<std::string> disabled_extensions_vec;
+    Tokenize(disabled_extensions, ", ;", &disabled_extensions_vec);
+
+    // Fill in filtered_exts_ vector first.
+    if (gfx::GetGLImplementation() !=
+        gfx::kGLImplementationDesktopGLCoreProfile) {
+      const char* gl_extensions = reinterpret_cast<const char*>(
+          GLApiBase::glGetStringFn(GL_EXTENSIONS));
+      if (gl_extensions)
+        base::SplitString(gl_extensions, ' ', &filtered_exts_);
+    } else {
+      GLint num_extensions = 0;
+      GLApiBase::glGetIntegervFn(GL_NUM_EXTENSIONS, &num_extensions);
+      for (GLint i = 0; i < num_extensions; ++i) {
+        const char* gl_extension = reinterpret_cast<const char*>(
+            GLApiBase::glGetStringiFn(GL_EXTENSIONS, i));
+        DCHECK(gl_extension != NULL);
+        filtered_exts_.push_back(gl_extension);
+      }
+    }
+
+    // Filter out extensions from the command line.
+    for (const std::string& disabled_ext : disabled_extensions_vec) {
+      filtered_exts_.erase(std::remove(filtered_exts_.begin(),
+                                       filtered_exts_.end(),
+                                       disabled_ext),
+                           filtered_exts_.end());
+    }
+
+    // Construct filtered extensions string for GL_EXTENSIONS string lookups.
+    filtered_exts_str_ = JoinString(filtered_exts_, " ");
+  }
+}
+
+void RealGLApi::glGetIntegervFn(GLenum pname, GLint* params) {
+  if (!filtered_exts_.empty() && pname == GL_NUM_EXTENSIONS) {

[no sievers, 2015/05/01 21:55:00]

nit: should it be DCHECK(!filtered_exts_.empty()) instead here and below?

[David Yen, 2015/05/01 22:34:38]

These are only filled if there are extensions disabled, otherwise it calls the
driver. Additionally, not calling the driver breaks our mock api class.

+    *params = static_cast<GLint>(filtered_exts_.size());
+  } else {
+    GLApiBase::glGetIntegervFn(pname, params);
+  }
+}
+
+const GLubyte* RealGLApi::glGetStringFn(GLenum name) {
+  if (!filtered_exts_.empty() && name == GL_EXTENSIONS) {
+    return reinterpret_cast<const GLubyte*>(filtered_exts_str_.c_str());
+  }
+  return GLApiBase::glGetStringFn(name);
+}
+
+const GLubyte* RealGLApi::glGetStringiFn(GLenum name, GLuint index) {
+  if (!filtered_exts_str_.empty() && name == GL_EXTENSIONS) {
+    if (index >= filtered_exts_.size()) {
+      return NULL;
+    }
+    return reinterpret_cast<const GLubyte*>(filtered_exts_[index].c_str());
+  }
+  return GLApiBase::glGetStringiFn(name, index);
 }
 
 void RealGLApi::glFlushFn() {
   GLApiBase::glFlushFn();
 }
 
 void RealGLApi::glFinishFn() {
   GLApiBase::glFinishFn();
 }
 
@@ skipping 114 matching lines @@
 ScopedSetGLToRealGLApi::ScopedSetGLToRealGLApi()
     : old_gl_api_(GetCurrentGLApi()) {
   SetGLToRealGLApi();
 }
 
 ScopedSetGLToRealGLApi::~ScopedSetGLToRealGLApi() {
   SetGLApi(old_gl_api_);
 }
 
 }  // namespace gfx