Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 11109016: Explicit 'all' target overrides implicit 'all' target.

Created:
8 years, 2 months ago by bungeman-chromium
Modified:
8 years, 1 month ago
Reviewers:
Mark Mentovai, Nico
CC:
gyp-developer_googlegroups.com, epoger
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M pylib/gyp/generator/make.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M pylib/gyp/generator/ninja.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
bungeman-chromium
8 years, 2 months ago (2012-10-12 16:10:52 UTC) #1
epoger
I don't think we (Skia) necessarily want to specify our own "all" target that only ...
8 years, 2 months ago (2012-10-12 16:19:14 UTC) #2
bungeman-chromium
Without this, Skia is going to have to create an 'everything' target and pretend that ...
8 years, 2 months ago (2012-10-12 19:32:41 UTC) #3
Sam Clegg
On 2012/10/12 19:32:41, bungeman2 wrote: > Without this, Skia is going to have to create ...
8 years, 2 months ago (2012-10-12 20:25:27 UTC) #4
bungeman-chromium
> Seems like you are saying that there is no easy/obvious way to get > ...
8 years, 2 months ago (2012-10-19 18:08:06 UTC) #5
bungeman-chromium
Based on discussion at gyp-developer, Patch Set 2 does not add any flags. Instead, the ...
8 years, 2 months ago (2012-10-20 06:02:45 UTC) #6
bungeman-chromium
8 years, 1 month ago (2012-10-25 15:27:11 UTC) #7
Mark, Patch Set 2 here seems to be what you were describing as to how gyp was
originally supposed to work. Is this accurate?

Powered by Google App Engine
This is Rietveld 408576698