chrome/common/extensions/PRESUBMIT.py - Issue 11109005: Fix c/c/extensions PRESUBMIT.py to only check _VERSION of docs/server2 files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/PRESUBMIT.py

Issue 11109005: Fix c/c/extensions PRESUBMIT.py to only check _VERSION of docs/server2 files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/PRESUBMIT.py

diff --git a/chrome/common/extensions/PRESUBMIT.py b/chrome/common/extensions/PRESUBMIT.py

index 52fe7052a46c34cde42dcef2b3fd58b9f054bf68..2e9a11474b82c6d4c4cb79ccd79828e00ef030bd 100644

--- a/chrome/common/extensions/PRESUBMIT.py

+++ b/chrome/common/extensions/PRESUBMIT.py

@@ -89,7 +89,10 @@ def _CheckHeadingIDs(input_api):

def _CheckVersions(input_api, output_api, results):

version = '_VERSION ='

for affected_file in input_api.AffectedFiles():

- if affected_file.LocalPath().endswith('PRESUBMIT.py'):

+ local_path = affected_file.LocalPath()

+ if not fnmatch.fnmatch(local_path, '%s*' % SERVER2_PATH):

+ continue

+ if local_path.endswith('PRESUBMIT.py'):

continue

if any(version in line for line in affected_file.NewContents()):

found = False

« no previous file with comments | « no previous file | no next file » | no next file with comments »