Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 1110883004: TabindexSaveFileDialog_FileManagerBrowserTest.Test_0/1/2 are failing on cros trunk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Browser test for basic Chrome OS file manager functionality: 5 // Browser test for basic Chrome OS file manager functionality:
6 // - The file list is updated when a file is added externally to the Downloads 6 // - The file list is updated when a file is added externally to the Downloads
7 // folder. 7 // folder.
8 // - Selecting a file and copy-pasting it with the keyboard copies the file. 8 // - Selecting a file and copy-pasting it with the keyboard copies the file.
9 // - Selecting a file and pressing delete deletes it. 9 // - Selecting a file and pressing delete deletes it.
10 10
(...skipping 1151 matching lines...) Expand 10 before | Expand all | Expand 10 after
1162 1162
1163 // http://crbug.com/480491 1163 // http://crbug.com/480491
1164 INSTANTIATE_TEST_CASE_P( 1164 INSTANTIATE_TEST_CASE_P(
1165 DISABLED_TabindexOpenDialog, 1165 DISABLED_TabindexOpenDialog,
1166 FileManagerBrowserTest, 1166 FileManagerBrowserTest,
1167 ::testing::Values( 1167 ::testing::Values(
1168 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"), 1168 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"),
1169 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"), 1169 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"),
1170 TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads"))); 1170 TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads")));
1171 1171
1172 // Fails on official build. http://crbug.com/482121.
1173 #if defined(OFFICIAL_BUILD)
1174 #define MAYBE_TabindexSaveFileDialog DISABLED_TabindexSaveFileDialog
1175 #else
1176 #define MAYBE_TabindexSaveFileDialog TabindexSaveFileDialog
1177 #endif
1172 INSTANTIATE_TEST_CASE_P( 1178 INSTANTIATE_TEST_CASE_P(
1173 TabindexSaveFileDialog, 1179 MAYBE_TabindexSaveFileDialog,
1174 FileManagerBrowserTest, 1180 FileManagerBrowserTest,
1175 ::testing::Values( 1181 ::testing::Values(
1176 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDrive"), 1182 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDrive"),
1177 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"), 1183 TestParameter(NOT_IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"),
1178 TestParameter(IN_GUEST_MODE, "tabindexSaveFileDialogDownloads"))); 1184 TestParameter(IN_GUEST_MODE, "tabindexSaveFileDialogDownloads")));
1179 1185
1180 // Fails on official build. http://crbug.com/429294 1186 // Fails on official build. http://crbug.com/429294
1181 // Disabled under MSAN as well. http://crbug.com/468980. 1187 // Disabled under MSAN as well. http://crbug.com/468980.
1182 #if !defined(NDEBUG) || defined(OFFICIAL_BUILD) || defined(MEMORY_SANITIZER) 1188 #if !defined(NDEBUG) || defined(OFFICIAL_BUILD) || defined(MEMORY_SANITIZER)
1183 #define MAYBE_OpenFileDialog DISABLED_OpenFileDialog 1189 #define MAYBE_OpenFileDialog DISABLED_OpenFileDialog
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 StartTest(); 1559 StartTest();
1554 } 1560 }
1555 1561
1556 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) { 1562 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) {
1557 set_test_case_name("openSingleVideoOnDrive"); 1563 set_test_case_name("openSingleVideoOnDrive");
1558 StartTest(); 1564 StartTest();
1559 } 1565 }
1560 1566
1561 } // namespace 1567 } // namespace
1562 } // namespace file_manager 1568 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698