App Launcher: Webstore results are now highlighted.

App Launcher: Webstore results are now highlighted.

We now highlight (in bold) the part of the query that you typed, just as
we do with other types of queries.

Moved AppResult::UpdateFromMatch into SearchResult so it can be used by
any provider.

BUG=481837
Committed: https://crrev.com/49d9c54f4cc57c5b413c608d32bd1dad8da9416f
Cr-Commit-Position: refs/heads/master@{#329356}

[Matt Giuca, 2015-04-28 08:09:53]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2015-04-30 04:29:26]

Patchset #2 (id:20001) has been deleted

[calamity, 2015-04-30 06:36:06]

lgtm

https://codereview.chromium.org/1110883003/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/app_result.cc (right):

https://codereview.chromium.org/1110883003/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/app_result.cc:116:
copy->set_relevance(relevance());
Hmm... Why was this not here before...?

https://codereview.chromium.org/1110883003/diff/40001/ui/app_list/search_resu...
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/1110883003/diff/40001/ui/app_list/search_resu...
ui/app_list/search_result.h:140: // Updates the results relevance score, and
sets its title and title tags,
nit: result's?

[Matt Giuca, 2015-05-11 04:53:21]

PTAL (after the other webstore related CLs).

https://codereview.chromium.org/1110883003/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/app_result.cc (right):

https://codereview.chromium.org/1110883003/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/app_result.cc:116:
copy->set_relevance(relevance());
Is not strictly necessary as the only caller of Duplicate sets the relevance to
a new value immediately after. But it's a mistake to not have it.

https://codereview.chromium.org/1110883003/diff/40001/ui/app_list/search_resu...
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/1110883003/diff/40001/ui/app_list/search_resu...
ui/app_list/search_result.h:140: // Updates the results relevance score, and
sets its title and title tags,
On 2015/04/30 06:36:06, calamity wrote:
> nit: result's?

Done.

[Matt Giuca, 2015-05-12 04:38:47]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-05-12 04:38:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1110883003/#ps100001
(title: "Update tests to test for highlighting.")

[commit-bot: I haz the power, 2015-05-12 04:39:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110883003/100001

[commit-bot: I haz the power, 2015-05-12 05:36:16]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-05-12 05:37:13]

Patchset 5 (id:??) landed as
https://crrev.com/49d9c54f4cc57c5b413c608d32bd1dad8da9416f
Cr-Commit-Position: refs/heads/master@{#329356}