Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2433)

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1110853002: Oilpan: In ASan, poison all unmarked objects before start sweeping (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/Heap.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.cpp
diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp
index beffb89b86f3e69dc88e594210b8e7ec02fe6302..699866a4516830374b32646ac8351c86a8c97e33 100644
--- a/Source/platform/heap/ThreadState.cpp
+++ b/Source/platform/heap/ThreadState.cpp
@@ -894,6 +894,16 @@ void ThreadState::preSweep()
ScriptForbiddenScope::exit();
}
+#if defined(ADDRESS_SANITIZER)
+// TODO(haraken): Currently we cannot enable the poisoning because we have
+// real bugs where destructors touch other on-heap objects. Remove all the bugs
+// and enable the poisoning.
+#if 0
+ for (int i = 0; i < NumberOfHeaps; i++)
+ m_heaps[i]->poisonUnmarkedObjects();
+#endif
+#endif
+
#if ENABLE(OILPAN)
if (gcState() == EagerSweepScheduled) {
// Eager sweeping should happen only in testing.
« no previous file with comments | « Source/platform/heap/Heap.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698