Issue 1110843003: Apply automated fixits for Chrome clang plugin to ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110843003: Apply automated fixits for Chrome clang plugin to ash. (Closed)

Created:
5 years, 7 months ago by dcheng

Modified:
5 years, 7 months ago

Reviewers:
Nico, oshima

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Apply automated fixits for Chrome clang plugin to ash. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=oshima Committed: https://crrev.com/9b85081a1e6c2c29e80378eb36fe9b9bab3751ae Cr-Commit-Position: refs/heads/master@{#327565}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	ash/host/ash_window_tree_host_win.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	ash/system/win/audio/tray_audio_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110843003/1

5 years, 7 months ago (2015-04-29 18:56:46 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 21:38:44 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9b85081a1e6c2c29e80378eb36fe9b9bab3751ae
Cr-Commit-Position: refs/heads/master@{#327565}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages