Change user_story.user_story_filter to story.story_filter

Change user_story.user_story_filter to story.story_filter

BUG=465594
Committed: https://crrev.com/b385e60e7d2da9497cca52222dd0dfc4f232fd5e
Cr-Commit-Position: refs/heads/master@{#327530}

[aiolos (Not reviewing), 2015-04-28 00:14:10]

aiolos@chromium.org changed reviewers:
+ nednguyen@google.com

[aiolos (Not reviewing), 2015-04-28 01:29:31]

Note that people should only be using this file as a reference for what options
to pass in, and should never be importing it outside of telemetry. So I don't
think we need to handle giving people time to switch over to the new name.

[nednguyen, 2015-04-28 20:23:01]

On 2015/04/28 01:29:31, aiolos wrote:
> Note that people should only be using this file as a reference for what
options
> to pass in, and should never be importing it outside of telemetry. So I don't
> think we need to handle giving people time to switch over to the new name.

How about just story.filter?

[aiolos (Not reviewing), 2015-04-28 20:32:58]

On 2015/04/28 20:23:01, nednguyen wrote:
> On 2015/04/28 01:29:31, aiolos wrote:
> > Note that people should only be using this file as a reference for what
> options
> > to pass in, and should never be importing it outside of telemetry. So I
don't
> > think we need to handle giving people time to switch over to the new name.
> 
> How about just story.filter?

That was the original plan, but "filter" overwrites the python built-in filter,
which we also use in user_story_runner. (In the same line as we use
story.story_flter) I think it would be better to  just avoid the confusion.

[aiolos (Not reviewing), 2015-04-28 20:33:39]

https://codereview.chromium.org/1110843002/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/1110843002/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/user_story/user_story_runner.py:182: user_stories =
filter(story_filter.StoryFilter.IsSelected,
This line gets confusing if we name it story.filter

[nednguyen, 2015-04-28 20:39:37]

On 2015/04/28 20:33:39, aiolos wrote:
>
https://codereview.chromium.org/1110843002/diff/20001/tools/telemetry/telemet...
> File tools/telemetry/telemetry/user_story/user_story_runner.py (right):
> 
>
https://codereview.chromium.org/1110843002/diff/20001/tools/telemetry/telemet...
> tools/telemetry/telemetry/user_story/user_story_runner.py:182: user_stories =
> filter(story_filter.StoryFilter.IsSelected,
> This line gets confusing if we name it story.filter

Ok. lgtm

[aiolos (Not reviewing), 2015-04-28 20:40:36]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2015-04-28 20:40:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110843002/20001

[commit-bot: I haz the power, 2015-04-28 23:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 23:12:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[aiolos (Not reviewing), 2015-04-29 18:14:27]

The CQ bit was checked by aiolos@chromium.org

[aiolos (Not reviewing), 2015-04-29 18:14:27]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1110843002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-29 18:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110843002/40001

[commit-bot: I haz the power, 2015-04-29 18:44:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-29 18:45:06]

Patchset 3 (id:??) landed as
https://crrev.com/b385e60e7d2da9497cca52222dd0dfc4f232fd5e
Cr-Commit-Position: refs/heads/master@{#327530}