[autofill] Sync server card and address metadata.

components/autofill/core/browser/webdata/autofill_change.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/webdata/autofill_change.h"
 
 #include "base/logging.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
 
 namespace autofill {
 
 AutofillChange::AutofillChange(Type type, const AutofillKey& key)
     : GenericAutofillChange<AutofillKey>(type, key) {
 }
 
 AutofillChange::~AutofillChange() {
 }
 
-AutofillProfileChange::AutofillProfileChange(
-  Type type, const std::string& key, const AutofillProfile* profile)
-    : GenericAutofillChange<std::string>(type, key),
-      profile_(profile) {
-  DCHECK(type == ADD ? (profile && profile->guid() == key) : true);
-  DCHECK(type == UPDATE ? (profile && profile->guid() == key) : true);
-  DCHECK(type == REMOVE ? !profile : true);
+AutofillProfileChange::AutofillProfileChange(Type type,
+                                             const std::string& key,
+                                             const AutofillProfile* profile)
+    : GenericAutofillChange<std::string>(type, key), profile_(profile) {
+  DCHECK((type == ADD && profile && profile->guid() == key) ||
+         (type == UPDATE && profile && profile->guid() == key) ||
+         (type == REMOVE && !profile));

[Peter Kasting, 2015/05/20 23:11:21]

Simpler:

  DCHECK((type == REMOVE) ? !profile : (profile && profile->guid() == key));

[please use gerrit instead, 2015/05/21 00:13:48]

That's a good one. I like that it's a one-liner.

 }
 
 AutofillProfileChange::~AutofillProfileChange() {
 }
 
 bool AutofillProfileChange::operator==(
     const AutofillProfileChange& change) const {
-  return type() == change.type() &&
-         key() == change.key() &&
-         (type() != REMOVE) ? *profile() == *change.profile() : true;
+  return type() == change.type() && key() == change.key() &&
+         (type() == REMOVE || *profile() == *change.profile());
+}
+
+CreditCardChange::CreditCardChange(Type type,
+                                   const std::string& key,
+                                   const CreditCard* card)
+    : GenericAutofillChange<std::string>(type, key), card_(card) {
+  DCHECK((type == ADD && card && card->guid() == key) ||
+         (type == UPDATE && card && card->guid() == key) ||
+         (type == REMOVE && !card));

[Peter Kasting, 2015/05/20 23:11:21]

Simpler:

  DCHECK((type == REMOVE) ? !card : (card && card->guid() == key));

[please use gerrit instead, 2015/05/21 00:13:48]

Ditto.

+}
+
+CreditCardChange::~CreditCardChange() {
+}
+
+bool CreditCardChange::operator==(const CreditCardChange& change) const {
+  return type() == change.type() && key() == change.key() &&
+         (type() == REMOVE || *card() == *change.card());
 }
 
 }  // namespace autofill