Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: cc/output/gl_renderer.cc

Issue 1110813002: Fix assert in GetOverlayRect when transforming video with Ozone overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reject non-integer rects in Ozone GBM validator Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/overlay_candidate.h » ('j') | ui/ozone/platform/drm/gbm_surface_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index ba3e07d5189bb209533e672c51aa62b786f25ce2..92910a442ed0d47ac9f5088e08c550ffc78fe32f 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -3444,11 +3444,12 @@ void GLRenderer::ScheduleOverlays(DrawingFrame* frame) {
make_scoped_ptr(new ResourceProvider::ScopedReadLockGL(
resource_provider_, overlay.resource_id)));
+ gfx::Rect display_rect(ToNearestRect(overlay.display_rect));
danakj 2015/05/04 19:56:41 i don't think the temp var is buying much here it'
halliwell 2015/05/04 21:38:16 yep, done.
context_support_->ScheduleOverlayPlane(
overlay.plane_z_order,
overlay.transform,
pending_overlay_resources_.back()->texture_id(),
- overlay.display_rect,
+ display_rect,
overlay.uv_rect);
}
}
« no previous file with comments | « no previous file | cc/output/overlay_candidate.h » ('j') | ui/ozone/platform/drm/gbm_surface_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698