Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2093)

Unified Diff: cc/output/gl_renderer.cc

Issue 1110813002: Fix assert in GetOverlayRect when transforming video with Ozone overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes display_rect to float Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/overlay_candidate.h » ('j') | cc/output/overlay_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index ba3e07d5189bb209533e672c51aa62b786f25ce2..92910a442ed0d47ac9f5088e08c550ffc78fe32f 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -3444,11 +3444,12 @@ void GLRenderer::ScheduleOverlays(DrawingFrame* frame) {
make_scoped_ptr(new ResourceProvider::ScopedReadLockGL(
resource_provider_, overlay.resource_id)));
+ gfx::Rect display_rect(ToNearestRect(overlay.display_rect));
context_support_->ScheduleOverlayPlane(
overlay.plane_z_order,
overlay.transform,
pending_overlay_resources_.back()->texture_id(),
- overlay.display_rect,
+ display_rect,
achaulk 2015/04/29 21:37:03 You'll still hit the same problem here, no? On you
halliwell 2015/04/29 21:42:54 Yep, unless we modify the transform when accepting
achaulk 2015/04/29 21:45:00 Probably change this to accept a float as well I w
overlay.uv_rect);
}
}
« no previous file with comments | « no previous file | cc/output/overlay_candidate.h » ('j') | cc/output/overlay_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698