Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: ui/ozone/public/overlay_candidates_ozone.h

Issue 1110813002: Fix assert in GetOverlayRect when transforming video with Ozone overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some nits. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/ozone/platform/drm/gbm_surface_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/public/overlay_candidates_ozone.h
diff --git a/ui/ozone/public/overlay_candidates_ozone.h b/ui/ozone/public/overlay_candidates_ozone.h
index ad26ebc7f8937702b79cdb6469163435f59d14f5..c5733300491ebddc0ba05e689b82016c36c4a878 100644
--- a/ui/ozone/public/overlay_candidates_ozone.h
+++ b/ui/ozone/public/overlay_candidates_ozone.h
@@ -27,8 +27,10 @@ class OZONE_BASE_EXPORT OverlayCandidatesOzone {
gfx::OverlayTransform transform;
// Format of the buffer to composite.
SurfaceFactoryOzone::BufferFormat format;
- // Rect on the display to position the overlay to.
- gfx::Rect display_rect;
+ // Rect on the display to position the overlay to. Input rectangle may
+ // not have integer coordinates, but when accepting for overlay, must
+ // be modified by CheckOverlaySupport to output integer values.
+ gfx::RectF display_rect;
// Crop within the buffer to be placed inside |display_rect|.
gfx::RectF crop_rect;
// Stacking order of the overlay plane relative to the main surface,
@@ -45,7 +47,9 @@ class OZONE_BASE_EXPORT OverlayCandidatesOzone {
// A list of possible overlay candidates is presented to this function.
// The expected result is that those candidates that can be in a separate
// plane are marked with |overlay_handled| set to true, otherwise they are
- // to be tranditionally composited.
+ // to be traditionally composited. When setting |overlay_handled| to true,
+ // the implementation must also snap |display_rect| to integer coordinates
+ // if necessary.
virtual void CheckOverlaySupport(OverlaySurfaceCandidateList* surfaces);
virtual ~OverlayCandidatesOzone();
« no previous file with comments | « ui/ozone/platform/drm/gbm_surface_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698