Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: lib/html/scripts/systemnative.py

Issue 11108017: Rename Dartium dart:html implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/html/scripts/systemhtml.py ('K') | « lib/html/scripts/systemhtml.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemnative.py
diff --git a/lib/html/scripts/systemnative.py b/lib/html/scripts/systemnative.py
index 17d45d3ced122cf53ee2480e3cea9b98963416c8..02407bd4256f72f979f995a25fd0f2912b7459dc 100644
--- a/lib/html/scripts/systemnative.py
+++ b/lib/html/scripts/systemnative.py
@@ -22,9 +22,6 @@ class DartiumBackend(object):
self._type_registry = options.type_registry
self._interface_type_info = self._type_registry.TypeInfo(self._interface.id)
- def ImplementationClassName(self):
- return self._ImplClassName(self._interface.id)
-
def ImplementsMergedMembers(self):
# We could not add merged functions to implementation class because
# underlying c++ object doesn't implement them. Merged functions are
@@ -175,9 +172,6 @@ class DartiumBackend(object):
self._interface.id,
'ConstructorRaisesException' in ext_attrs)
- def _ImplClassName(self, interface_name):
- return '_%sImpl' % interface_name
-
def BaseClassName(self):
root_class = 'NativeFieldWrapperClass1'
@@ -197,7 +191,7 @@ class DartiumBackend(object):
if IsDartListType(supertype) or IsDartCollectionType(supertype):
return root_class
- return self._ImplClassName(supertype)
+ return self._type_registry.TypeInfo(supertype).implementation_name()
ATTRIBUTES_OF_CONSTRUCTABLE = set([
'CustomConstructor',
@@ -242,7 +236,7 @@ class DartiumBackend(object):
INCLUDES=self._GenerateCPPIncludes(self._cpp_impl_includes),
CALLBACKS=self._cpp_definitions_emitter.Fragments(),
RESOLVER=self._cpp_resolver_emitter.Fragments(),
- DART_IMPLEMENTATION_CLASS=self.ImplementationClassName())
+ DART_IMPLEMENTATION_CLASS=self._interface_type_info.implementation_name())
def _GenerateCPPHeader(self):
to_native_emitter = emitter.Emitter()
« lib/html/scripts/systemhtml.py ('K') | « lib/html/scripts/systemhtml.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698