Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 11108014: [dart2dart] Fix assertions for tests to pass in checked mode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart
diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
index 381b5da132b309018184d307446b06854324bca4..6e815c1ab99b07b182e4d9d247a4c2cc2e0339cc 100644
--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart
+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
@@ -394,7 +394,10 @@ class PlaceholderCollector extends Visitor {
if (send.receiver !== null) tryMakeMemberPlaceholder(send.selector);
} else if (!element.isErroneous()) {
if (Elements.isStaticOrTopLevel(element)) {
- assert(element is VariableElement || element.isAccessor());
+ // TODO(smok): Worth investigating why sometimes we get getter/setter
+ // here and sometimes abstract field.
+ assert(element is VariableElement || element.isAccessor()
+ || element.isAbstractField() || element.isFunction());
makeElementPlaceholder(send.selector, element);
} else {
assert(send.selector is Identifier);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698