Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: dart/lib/isolate/timer.dart

Issue 11108007: Add warning for future maintainers of Timer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 abstract class Timer { 5 abstract class Timer {
6 /** 6 /**
7 * Creates a new timer. The [callback] callback is invoked after 7 * Creates a new timer. The [callback] callback is invoked after
8 * [milliSeconds] milliseconds. 8 * [milliSeconds] milliseconds.
9 */ 9 */
10 factory Timer(int milliSeconds, void callback(Timer timer)) { 10 factory Timer(int milliSeconds, void callback(Timer timer)) {
(...skipping 24 matching lines...) Expand all
35 // factory constructors in the VM. 35 // factory constructors in the VM.
36 36
37 typedef Timer _TimerFactoryClosure(int milliSeconds, 37 typedef Timer _TimerFactoryClosure(int milliSeconds,
38 void callback(Timer timer), 38 void callback(Timer timer),
39 bool repeating); 39 bool repeating);
40 40
41 class _TimerFactory { 41 class _TimerFactory {
42 static _TimerFactoryClosure _factory; 42 static _TimerFactoryClosure _factory;
43 } 43 }
44 44
45 // TODO(ahe): Warning: this is NOT called by Dartium. Instead, it sets
46 // [_TimerFactory._factory] directly.
45 void _setTimerFactoryClosure(_TimerFactoryClosure closure) { 47 void _setTimerFactoryClosure(_TimerFactoryClosure closure) {
46 _TimerFactory._factory = closure; 48 _TimerFactory._factory = closure;
47 } 49 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698