Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1110783003: Apply automated fixits for Chrome clang plugin to base. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to base. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 Committed: https://crrev.com/1834ea9d2dc23ef577efd8e53b9764e17412972a Cr-Commit-Position: refs/heads/master@{#327542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M base/win/scoped_variant_unittest.cc View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:52:01 UTC) #2
Nico
lgtm (Oh, I thought you'd just do one CL for everything – shouldn't be all ...
5 years, 7 months ago (2015-04-29 18:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110783003/1
5 years, 7 months ago (2015-04-29 18:55:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:16:14 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:17:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1834ea9d2dc23ef577efd8e53b9764e17412972a
Cr-Commit-Position: refs/heads/master@{#327542}

Powered by Google App Engine
This is Rietveld 408576698