Handle transient LogOut errors with retry and backoff.

Handle transient LogOut errors with retry and backoff.

BUG=466799
Committed: https://crrev.com/c3a1754b98350d2372bb9dc213de5d0b6a186716
Cr-Commit-Position: refs/heads/master@{#327287}

[Mike Lerman, 2015-04-27 20:21:01]

mlerman@chromium.org changed reviewers:
+ rogerta@chromium.org

[Mike Lerman, 2015-04-27 20:21:02]

Hi Roger,

Another small CL for the Cookie Manager. After this I'm on to the ChromeOS
ports!

[Roger Tawa OOO till Jul 10th, 2015-04-27 21:23:05]

lgtm, but one question and one nit

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
File components/signin/core/browser/gaia_cookie_manager_service.cc (right):

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service.cc:418:
fetcher_retries_ = 0;
Is it safe to reset the retries count?  What if the current pending request is
in a retry state?  Maybe only do this at line 420 below?

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
File components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
(right):

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service_unittest.cc:371:
SimulateLogoutSuccess(&helper, failed_fetcher());
Nit: maybe rename this function to SimulateLogoutComplete()?  Seems strange to
call a success method with a failed fetcher.

[Mike Lerman, 2015-04-28 13:27:25]

Thanks, Roger!

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
File components/signin/core/browser/gaia_cookie_manager_service.cc (right):

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service.cc:418:
fetcher_retries_ = 0;
On 2015/04/27 21:23:05, Roger Tawa wrote:
> Is it safe to reset the retries count?  What if the current pending request is
> in a retry state?  Maybe only do this at line 420 below?

Great catch - thanks! Done.

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
File components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
(right):

https://codereview.chromium.org/1110743002/diff/20001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service_unittest.cc:371:
SimulateLogoutSuccess(&helper, failed_fetcher());
On 2015/04/27 21:23:05, Roger Tawa wrote:
> Nit: maybe rename this function to SimulateLogoutComplete()?  Seems strange to
> call a success method with a failed fetcher.

Done.

[Mike Lerman, 2015-04-28 13:58:37]

The CQ bit was checked by mlerman@chromium.org

[Mike Lerman, 2015-04-28 13:58:37]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1110743002/#ps40001
(title: "rogerta's comments")

[commit-bot: I haz the power, 2015-04-28 13:58:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110743002/40001

[commit-bot: I haz the power, 2015-04-28 14:48:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 14:50:39]

Patchset 3 (id:??) landed as
https://crrev.com/c3a1754b98350d2372bb9dc213de5d0b6a186716
Cr-Commit-Position: refs/heads/master@{#327287}