Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 111073003: Cleanup of QUIC stream classes. (Closed)

Created:
7 years ago by ramant (doing other things)
Modified:
7 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Cleanup of QUIC stream classes. Remove abstract QuicReliableClientStream class and fold it into the derived QuicSpdyClientStream class. Remove abstract QuicReliableServerStream class and fold it into the derived QuicSpdyServerStream class. Merge internal change: 57751931 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -614 lines) Patch
M net/net.gyp View 2 chunks +1 line, -6 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_client.h View 4 chunks +2 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 3 chunks +2 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D net/tools/quic/quic_reliable_client_stream.h View 1 chunk +0 lines, -66 lines 0 comments Download
D net/tools/quic/quic_reliable_client_stream.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D net/tools/quic/quic_reliable_client_stream_test.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D net/tools/quic/quic_reliable_server_stream.h View 1 chunk +0 lines, -66 lines 0 comments Download
D net/tools/quic/quic_reliable_server_stream.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D net/tools/quic/quic_reliable_server_stream_test.cc View 1 chunk +0 lines, -230 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +29 lines, -6 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 6 chunks +19 lines, -6 lines 0 comments Download
A + net/tools/quic/quic_spdy_client_stream_test.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 3 chunks +30 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 5 chunks +40 lines, -6 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 2 chunks +201 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
7 years ago (2013-12-10 01:46:10 UTC) #1
Ryan Hamilton
7 years ago (2013-12-11 23:55:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698