Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: build/config/features.gni

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index 387345827867df713daafff67229dc1c1702d967..9f6a35a3f58ad3c3951e9f30fd7b54df5c4279f8 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -85,12 +85,12 @@ declare_args() {
# (e.g. Android and ChromeCast) that use a browser side CDM.
enable_browser_cdms = is_android
- # Variable safe_browsing is used to control the build time configuration for
- # safe browsing feature. Safe browsing can be compiled in 3 different levels:
- # 0 disables it, 1 enables it fully, and 2 enables only UI and reporting
- # features without enabling phishing and malware detection. This is useful to
- # integrate a third party phishing/malware detection to existing safe browsing
- # logic.
+ # Variable safe_browsing is used to control the build time configuration
+ # for safe browsing feature. Safe browsing can be compiled in 4 different
+ # levels: 0 disables it, 1 enables it fully, and 2 enables only UI and
+ # reporting features for use with Data Saver on Mobile, and 3 enables
+ # extended mobile protection via an external API. When 3 is fully deployed,
+ # it will replace 2.
if (is_android) {
safe_browsing_mode = 2
} else if (is_ios) {

Powered by Google App Engine
This is Rietveld 408576698