Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: build/common.gypi

Issue 1110723002: Split to SafeBrowsingDatabaseManager into Local* and Remote*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to review. Tweak comments and list initializer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 # currently only works on Linux. 364 # currently only works on Linux.
365 'use_third_party_translations%': 0, 365 'use_third_party_translations%': 0,
366 366
367 # Remoting compilation is enabled by default. Set to 0 to disable. 367 # Remoting compilation is enabled by default. Set to 0 to disable.
368 'remoting%': 1, 368 'remoting%': 1,
369 369
370 # Configuration policy is enabled by default. Set to 0 to disable. 370 # Configuration policy is enabled by default. Set to 0 to disable.
371 'configuration_policy%': 1, 371 'configuration_policy%': 1,
372 372
373 # Variable safe_browsing is used to control the build time configuration 373 # Variable safe_browsing is used to control the build time configuration
374 # for safe browsing feature. Safe browsing can be compiled in 3 different 374 # for safe browsing feature. Safe browsing can be compiled in 4 different
375 # levels: 0 disables it, 1 enables it fully, and 2 enables only UI and 375 # levels: 0 disables it, 1 enables it fully, and 2 enables only UI and
376 # reporting features without enabling phishing and malware detection. This 376 # reporting features for use with Data Saver on Mobile, and 3 enables
377 # is useful to integrate a third party phishing/malware detection to 377 # extended mobile protection via an external API. When 3 is fully
378 # existing safe browsing logic. 378 # deployed, it will replace 2.
379 'safe_browsing%': 1, 379 'safe_browsing%': 1,
380 380
381 # Web speech is enabled by default. Set to 0 to disable. 381 # Web speech is enabled by default. Set to 0 to disable.
382 'enable_web_speech%': 1, 382 'enable_web_speech%': 1,
383 383
384 # Notifications are compiled in by default. Set to 0 to disable. 384 # Notifications are compiled in by default. Set to 0 to disable.
385 'notifications%' : 1, 385 'notifications%' : 1,
386 386
387 # Use dsymutil to generate real .dSYM files on Mac. The default is 0 for 387 # Use dsymutil to generate real .dSYM files on Mac. The default is 0 for
388 # regular builds and 1 for ASan builds. 388 # regular builds and 1 for ASan builds.
(...skipping 2619 matching lines...) Expand 10 before | Expand all | Expand 10 after
3008 }], 3008 }],
3009 ['v8_use_external_startup_data==1', { 3009 ['v8_use_external_startup_data==1', {
3010 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'], 3010 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'],
3011 }], 3011 }],
3012 3012
3013 # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service. 3013 # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service.
3014 # SAFE_BROWSING_DB_LOCAL - service manages a local database. 3014 # SAFE_BROWSING_DB_LOCAL - service manages a local database.
3015 # SAFE_BROWSING_DB_REMOTE - service talks via API to a database 3015 # SAFE_BROWSING_DB_REMOTE - service talks via API to a database
3016 # SAFE_BROWSING_CSD - enable client-side phishing detection. 3016 # SAFE_BROWSING_CSD - enable client-side phishing detection.
3017 ['safe_browsing==1', { 3017 ['safe_browsing==1', {
3018 # TODO(nparker): Remove existing uses of FULL_SAFE_BROWSING
3019 'defines': [ 3018 'defines': [
3019 # TODO(nparker): Remove existing uses of FULL_SAFE_BROWSING
3020 'FULL_SAFE_BROWSING', 3020 'FULL_SAFE_BROWSING',
3021 'SAFE_BROWSING_CSD', 3021 'SAFE_BROWSING_CSD',
3022 'SAFE_BROWSING_DB_LOCAL', 3022 'SAFE_BROWSING_DB_LOCAL',
3023 'SAFE_BROWSING_SERVICE', 3023 'SAFE_BROWSING_SERVICE',
3024 ], 3024 ],
3025 }], 3025 }],
3026 ['safe_browsing==2', { 3026 ['safe_browsing==2', {
3027 'defines': [ 3027 'defines': [
3028 # TODO(nparker): Remove existing uses of MOBILE_SAFE_BROWSING 3028 # TODO(nparker): Remove existing uses of MOBILE_SAFE_BROWSING
3029 'MOBILE_SAFE_BROWSING', 3029 'MOBILE_SAFE_BROWSING',
3030 'SAFE_BROWSING_SERVICE', 3030 'SAFE_BROWSING_SERVICE',
3031 ], 3031 ],
3032 }], 3032 }],
3033 ['safe_browsing==3', {
3034 'defines': [
3035 # TODO(nparker): Remove existing uses of MOBILE_SAFE_BROWSING
3036 'MOBILE_SAFE_BROWSING',
3037 'SAFE_BROWSING_DB_REMOTE',
3038 'SAFE_BROWSING_SERVICE',
3039 ],
3040 }],
3033 ], # conditions for 'target_defaults' 3041 ], # conditions for 'target_defaults'
3034 'target_conditions': [ 3042 'target_conditions': [
3035 ['<(use_libpci)==1', { 3043 ['<(use_libpci)==1', {
3036 'defines': ['USE_LIBPCI=1'], 3044 'defines': ['USE_LIBPCI=1'],
3037 }], 3045 }],
3038 ['<(use_openssl)==1', { 3046 ['<(use_openssl)==1', {
3039 'defines': ['USE_OPENSSL=1'], 3047 'defines': ['USE_OPENSSL=1'],
3040 }], 3048 }],
3041 ['<(use_openssl_certs)==1', { 3049 ['<(use_openssl_certs)==1', {
3042 'defines': ['USE_OPENSSL_CERTS=1'], 3050 'defines': ['USE_OPENSSL_CERTS=1'],
(...skipping 3144 matching lines...) Expand 10 before | Expand all | Expand 10 after
6187 # settings in target dicts. SYMROOT is a special case, because many other 6195 # settings in target dicts. SYMROOT is a special case, because many other
6188 # Xcode variables depend on it, including variables such as 6196 # Xcode variables depend on it, including variables such as
6189 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6197 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6190 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6198 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6191 # files to appear (when present) in the UI as actual files and not red 6199 # files to appear (when present) in the UI as actual files and not red
6192 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6200 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6193 # and therefore SYMROOT, needs to be set at the project level. 6201 # and therefore SYMROOT, needs to be set at the project level.
6194 'SYMROOT': '<(DEPTH)/xcodebuild', 6202 'SYMROOT': '<(DEPTH)/xcodebuild',
6195 }, 6203 },
6196 } 6204 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698