Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 1110693002: Revise Control+key restriction for XKB layouts. (Closed)

Created:
5 years, 8 months ago by kpschoedel
Modified:
5 years, 8 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revise Control+key restriction for XKB layouts. R=spang BUG=444048 Committed: https://crrev.com/104a1d8e282c9e05687e2526376e4eafb04f99ca Cr-Commit-Position: refs/heads/master@{#327099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kpschoedel
Extracted XKB-specific change from https://codereview.chromium.org/1072193004/
5 years, 8 months ago (2015-04-27 19:01:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110693002/1
5 years, 8 months ago (2015-04-27 19:02:57 UTC) #3
spang
lgtm
5 years, 8 months ago (2015-04-27 19:10:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-27 19:10:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110693002/1
5 years, 8 months ago (2015-04-27 19:11:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 19:12:56 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:14:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/104a1d8e282c9e05687e2526376e4eafb04f99ca
Cr-Commit-Position: refs/heads/master@{#327099}

Powered by Google App Engine
This is Rietveld 408576698