Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1110683002: Plugin Power Saver: Add browsertest for poster attribute on object tag directly. (Closed)

Created:
5 years, 7 months ago by tommycli
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Add browsertest for poster attribute on object tag directly. BUG=475653 Committed: https://crrev.com/1741512212c08138ad0fb614d08e4b496ea92d6d Cr-Commit-Position: refs/heads/master@{#327132}

Patch Set 1 #

Patch Set 2 : add size to embed tags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 1 chunk +24 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110683002/1
5 years, 7 months ago (2015-04-27 18:56:27 UTC) #3
tommycli
groby/thestig: PTAL Let me know if I missed any poster syntax cases to test in ...
5 years, 7 months ago (2015-04-27 18:56:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110683002/20001
5 years, 7 months ago (2015-04-27 18:59:59 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-27 19:32:59 UTC) #8
Lei Zhang
lgtm
5 years, 7 months ago (2015-04-27 20:27:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110683002/20001
5 years, 7 months ago (2015-04-27 20:51:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-27 21:31:54 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:34:12 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1741512212c08138ad0fb614d08e4b496ea92d6d
Cr-Commit-Position: refs/heads/master@{#327132}

Powered by Google App Engine
This is Rietveld 408576698