Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1110653002: SEGV in CFX_BaseSegmentedArray::Iterate() when CS has malformed dictionary. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, palmer
CC:
pdfium-reviews_googlegroups.com, palmer
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

SEGV in CFX_BaseSegmentedArray::Iterate() when CS has malformed dictionary. Failure to check document-controlled value before using it. BUG=481363 R=palmer@chromium.org, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bb93b0ba5b3c430d3b996e2c009d48feb17a44c3

Patch Set 1 : Test case only. SEGVs when run. #

Patch Set 2 : Fix SEGV. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
A testing/resources/bug_481363.in View 1 chunk +52 lines, -0 lines 0 comments Download
A testing/resources/bug_481363.pdf View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review. Palmer, FYI.
5 years, 8 months ago (2015-04-27 18:09:59 UTC) #2
palmer
LGTM FWIW.
5 years, 8 months ago (2015-04-27 18:14:10 UTC) #4
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-27 20:17:57 UTC) #5
Tom Sepez
5 years, 8 months ago (2015-04-27 20:24:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bb93b0ba5b3c430d3b996e2c009d48feb17a44c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698