Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1110623002: PPC: Don't MISS if you read the hole from certain FastHoley arrays. (Closed)

Created:
5 years, 8 months ago by MTBrandyberry
Modified:
5 years, 8 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Don't MISS if you read the hole from certain FastHoley arrays. Port caeb9004f0bfc2a916fc63e9d27100a3110016d4 Original commit message: If the array's map is the initial FastHoley array map, and the array prototype chain is undisturbed and empty of elements, then keyed loads can convert the load of a hole to undefined. BUG= R=dstence@us.ibm.com, michael_dawson@ca.ibm.com Committed: https://crrev.com/63d14580d8735cee070315bcf06403fba5ef0437 Cr-Commit-Position: refs/heads/master@{#28089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
Implement PPC support.
5 years, 8 months ago (2015-04-27 16:16:42 UTC) #1
michael_dawson
On 2015/04/27 16:16:42, mtbrandyberry wrote: > Implement PPC support. lgtm.
5 years, 8 months ago (2015-04-27 16:21:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110623002/1
5 years, 8 months ago (2015-04-27 16:22:33 UTC) #4
dstence
On 2015/04/27 16:22:33, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-27 16:24:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 17:01:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 17:02:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63d14580d8735cee070315bcf06403fba5ef0437
Cr-Commit-Position: refs/heads/master@{#28089}

Powered by Google App Engine
This is Rietveld 408576698