Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1110603005: Remove support for malloc'd typed arrays (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove support for malloc'd typed arrays All typed arrays should be allocated through the array buffer allocator BUG=none R=dcarney@chromium.org LOG=n Committed: https://crrev.com/b584bab2f5c9c2ddf10b759122a2e01d87b7ea79 Cr-Commit-Position: refs/heads/master@{#28105}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -31 lines) Patch
M samples/process.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/d8.cc View 1 2 chunks +9 lines, -5 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/snapshot/mksnapshot.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M test/unittests/run-all-unittests.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/parser-shell.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-28 10:24:08 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-04-28 11:13:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110603005/20001
5 years, 7 months ago (2015-04-28 11:23:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 11:25:30 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 11:25:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b584bab2f5c9c2ddf10b759122a2e01d87b7ea79
Cr-Commit-Position: refs/heads/master@{#28105}

Powered by Google App Engine
This is Rietveld 408576698