drive: Add the local largest changestamp to chrome:drive-internals

chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/drive_internals_ui.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"

[Haruki Sato, 2012/10/15 07:10:29]

If we don't use Int64ToString in this file,
can we remove this line as well?

[satorux1, 2012/10/16 05:02:56]

Done. good catch!

 #include "base/stringprintf.h"
 #include "base/sys_info.h"
 #include "chrome/browser/chromeos/drive/drive.pb.h"
 #include "chrome/browser/chromeos/drive/drive_cache.h"
 #include "chrome/browser/chromeos/drive/drive_file_system_interface.h"
+#include "chrome/browser/chromeos/drive/drive_resource_metadata.h"
 #include "chrome/browser/chromeos/drive/drive_service_interface.h"
 #include "chrome/browser/chromeos/drive/drive_system_service.h"
 #include "chrome/browser/google_apis/auth_service.h"
 #include "chrome/browser/google_apis/drive_api_parser.h"
 #include "chrome/browser/google_apis/gdata_errorcode.h"
 #include "chrome/browser/google_apis/gdata_util.h"
 #include "chrome/browser/google_apis/gdata_wapi_parser.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
 #include "chrome/common/url_constants.h"
@@ skipping 201 matching lines @@
   base::DictionaryValue account_metadata;
 
   if (gdata::util::IsDriveV2ApiEnabled()) {
     scoped_ptr<gdata::AboutResource> about_resource;
     about_resource = gdata::AboutResource::CreateFrom(*data);
 
     account_metadata.SetDouble("account-quota-total",
                                about_resource->quota_bytes_total());
     account_metadata.SetDouble("account-quota-used",
                                about_resource->quota_bytes_used());
-    account_metadata.SetString(
-        "account-largest-changestamp",
-        base::Int64ToString(about_resource->largest_change_id()));
+    account_metadata.SetDouble("account-largest-changestamp-remote",

[Haruki Sato, 2012/10/15 07:10:29]

I personally like string here as they are considered IDs.
Are we comparing those changestamps to show any message in drive-internals?
e.g.
if (local < remote)
  show("stale. need to sync.")
else
  show("latest. things in sync.")
maybe in JS?

[satorux1, 2012/10/16 05:02:56]

These are not IDs. These are monotonically increasing numbers which can be
compared, hence using double should be fine.

+                               about_resource->largest_change_id());
 
     // TODO(haruki): Fill installed Drive apps for Drive API.
     // http://crbug.com/154241
     return;
   } else {
     scoped_ptr<gdata::AccountMetadataFeed> feed;
     feed = gdata::AccountMetadataFeed::CreateFrom(*data);
 
     account_metadata.SetDouble("account-quota-total",
                                feed->quota_bytes_total());
     account_metadata.SetDouble("account-quota-used", feed->quota_bytes_used());
-    account_metadata.SetString(
-        "account-largest-changestamp",
-        base::Int64ToString(feed->largest_changestamp()));
+    account_metadata.SetDouble("account-largest-changestamp-remote",
+                               feed->largest_changestamp());
 
     base::ListValue* installed_apps = new base::ListValue();
     for (size_t i = 0; i < feed->installed_apps().size(); ++i) {
       const gdata::InstalledApp* app = feed->installed_apps()[i];
       base::DictionaryValue* app_data = new base::DictionaryValue();
       app_data->SetString("app_name", app->app_name());
       app_data->SetString("app_id", app->app_id());
       app_data->SetString("object_type", app->object_type());
       app_data->SetBoolean("supports_create", app->supports_create());
 
       installed_apps->Append(app_data);
     }
     account_metadata.Set("installed-apps", installed_apps);
   }
 
+  // Add the local largest chargestamp.
+  const drive::DriveResourceMetadata* resource_metadata =
+      GetSystemService()->file_system()->GetResourceMetadata();
+  const int64 largest_changestamp = resource_metadata->largest_changestamp();
+  account_metadata.SetDouble("account-largest-changestamp-local",
+                             largest_changestamp);
+
   web_ui()->CallJavascriptFunction("updateAccountMetadata", account_metadata);
 }
 
 void DriveInternalsWebUIHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
       "pageLoaded",
       base::Bind(&DriveInternalsWebUIHandler::OnPageLoaded,
                  weak_ptr_factory_.GetWeakPtr()));
   web_ui()->RegisterMessageCallback(
       "periodicUpdate",
@@ skipping 226 matching lines @@
       new ChromeWebUIDataSource(chrome::kChromeUIDriveInternalsHost);
   source->add_resource_path("drive_internals.css", IDR_DRIVE_INTERNALS_CSS);
   source->add_resource_path("drive_internals.js", IDR_DRIVE_INTERNALS_JS);
   source->set_default_resource(IDR_DRIVE_INTERNALS_HTML);
 
   Profile* profile = Profile::FromWebUI(web_ui);
   ChromeURLDataManager::AddDataSource(profile, source);
 }
 
 }  // namespace chromeos