drive: Rename 'gdata' namespace to 'drive' in chrome/browser/chromeos/drive

drive: Rename 'gdata' namespace to 'drive' in chrome/browser/chromeos/drive

'gdata' namespace was a misnomer. 'drive' should be a better name for code
in 'drive' directory, which implements the C++ side of Google Drive on
Chrome OS.

BUG=136371
TEST=compiles
TBR=thestig@chromium.org
# for changes outside of 'chromeos', which is just s/gdata::/drive::/g. i'm glad that strlen("gdata") == strlen("drive")

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161523

[satorux1, 2012-10-12 04:35:28]

today's patch...

[hashimoto, 2012-10-12 04:57:46]

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_api_service.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_api_service.h:46: virtual
gdata::OperationProgressStatusList GetProgressStatusList()
nit: Can we have a newline just after '(' like Authenticate() below?

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_file_system.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_file_system.h:17: #include
"chrome/browser/chromeos/drive/gdata_wapi_feed_loader.h"
Why did you add this include?

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_file_system_proxy.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_file_system_proxy.h:194: }  // namespace
chromeos
Though this is not your fault, please change this to 'drive'.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_service_interface.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_service_interface.h:12: //
gdata::DownloadActionCallback/gdata::InitiateUploadParams/ResulmeUploadParams
extremely tiny nit: I think OLD comment looks nicer.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/gdata_wapi_service.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/gdata_wapi_service.h:125: Profile* profile_;
Why are you adding this?

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/stale_cache_files_remover.cc (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/stale_cache_files_remover.cc:95:
scoped_ptr<drive::DriveEntryProto> entry_proto) {
nit: No need to have 'drive'?

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/stale_cache_files_remover.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/stale_cache_files_remover.h:56:
scoped_ptr<drive::DriveEntryProto> entry_proto);
nit: No need to have 'drive::'?

[satorux1, 2012-10-12 05:32:55]

Thank you for taking a look at the gigantic patch!

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_api_service.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_api_service.h:46: virtual
gdata::OperationProgressStatusList GetProgressStatusList()
On 2012/10/12 04:57:46, hashimoto wrote:
> nit: Can we have a newline just after '(' like Authenticate() below?

tried but looked awkward without parameters.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_file_system.cc (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_file_system.cc:861:
gdata::RunTaskOnUIThread(base::Bind(&DriveFileSystem::CopyOnUIThread,
fixed the indent, and elsewhere in the file.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_file_system.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_file_system.h:17: #include
"chrome/browser/chromeos/drive/gdata_wapi_feed_loader.h"
On 2012/10/12 04:57:46, hashimoto wrote:
> Why did you add this include?

Removed. Fixed.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_file_system_proxy.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_file_system_proxy.h:194: }  // namespace
chromeos
On 2012/10/12 04:57:46, hashimoto wrote:
> Though this is not your fault, please change this to 'drive'.

Done.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/drive_service_interface.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/drive_service_interface.h:12: //
gdata::DownloadActionCallback/gdata::InitiateUploadParams/ResulmeUploadParams
On 2012/10/12 04:57:46, hashimoto wrote:
> extremely tiny nit: I think OLD comment looks nicer.

Agreed. Done

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/gdata_wapi_service.cc (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/gdata_wapi_service.cc:147: new
gdata::GetDocumentsOperation(operation_registry(),
fixed the indent, and elsewhere in the file.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/gdata_wapi_service.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/gdata_wapi_service.h:125: Profile* profile_;
On 2012/10/12 04:57:46, hashimoto wrote:
> Why are you adding this?

This was removed by tzik. Somehow my patch got it back... Removed again.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/stale_cache_files_remover.cc (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/stale_cache_files_remover.cc:95:
scoped_ptr<drive::DriveEntryProto> entry_proto) {
On 2012/10/12 04:57:46, hashimoto wrote:
> nit: No need to have 'drive'?

Done.

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
File chrome/browser/chromeos/drive/stale_cache_files_remover.h (right):

http://codereview.chromium.org/11106007/diff/1/chrome/browser/chromeos/drive/...
chrome/browser/chromeos/drive/stale_cache_files_remover.h:56:
scoped_ptr<drive::DriveEntryProto> entry_proto);
On 2012/10/12 04:57:46, hashimoto wrote:
> nit: No need to have 'drive::'?

Done.

[hashimoto, 2012-10-12 05:37:30]

lgtm

[commit-bot: I haz the power, 2012-10-12 06:05:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/11106007/11001

[commit-bot: I haz the power, 2012-10-12 06:27:43]

Retried try job too often for step(s) interactive_ui_tests, jingle_unittests,
gpu_unittests, base_unittests, sync_integration_tests, sql_unittests,
chrome_frame_unittests, content_unittests, safe_browsing_tests, ipc_tests,
mini_installer_test, cacheinvalidation_unittests, remoting_unittests,
browser_tests, net_unittests, installer_util_unittests, chrome_frame_net_tests,
check_deps, crypto_unittests, unit_tests, nacl_integration, media_unittests,
content_browsertests, printing_unittests, sync_unit_tests