Issue 1110553002: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap in gin_java_bridge_object.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110553002: replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap in gin_java_bridge_object.h (Closed)

Created:
5 years, 8 months ago by dcarney

Modified:
5 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

replace to be deprecated v8::PersistentValueMap with v8::GlobalValueMap in gin_java_bridge_object.h BUG= Committed: https://crrev.com/430bee4913e40ca801c00099033996db203e68f4 Cr-Commit-Position: refs/heads/master@{#327045}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/java/gin_java_bridge_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110553002/1

5 years, 8 months ago (2015-04-27 13:55:57 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 14:52:28 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/430bee4913e40ca801c00099033996db203e68f4
Cr-Commit-Position: refs/heads/master@{#327045}