Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1110513002: Reland "Lazily register prototype users..." (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Lazily register prototype users..." ...when handing out validity cells to handlers; because invalidating said cells is the only time we'll need the user registrations. Along the way, fix a corner case in WeakFixedArray, which can now be empty after the recently introduced compaction support. This reverts commit 968715c653b6337252a05a0224a7a93fab3b0866. Original review: https://codereview.chromium.org/1104813004/ Committed: https://crrev.com/f6187fb3b52e518ccefd5de1bd1d4aca12bacba2 Cr-Commit-Position: refs/heads/master@{#28076}

Patch Set 1 : original patch #

Patch Set 2 : fix #

Patch Set 3 : assert trumps comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -76 lines) Patch
M src/objects.h View 5 chunks +16 lines, -8 lines 0 comments Download
M src/objects.cc View 1 2 13 chunks +117 lines, -68 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/prototype-changes.js View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL. You've seen patch set 1 before.
5 years, 7 months ago (2015-04-27 12:26:10 UTC) #2
Yang
lgtm
5 years, 7 months ago (2015-04-27 12:27:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110513002/40001
5 years, 7 months ago (2015-04-27 12:27:53 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-27 13:00:02 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 13:00:18 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f6187fb3b52e518ccefd5de1bd1d4aca12bacba2
Cr-Commit-Position: refs/heads/master@{#28076}

Powered by Google App Engine
This is Rietveld 408576698