Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1110503002: [turbofan] Reland: Optimize loads from the global object in JSTypeFeedbackSpecializer. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reland: Optimize loads from the global object in JSTypeFeedbackSpecializer. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/6e82fbfbaf29e1862673795c10d634e1465bfb47 Cr-Commit-Position: refs/heads/master@{#28073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -20 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-type-feedback.h View 4 chunks +10 lines, -2 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 6 chunks +100 lines, -16 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 3 chunks +9 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/global-delete.js View 1 chunk +73 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/global-var-delete.js View 1 chunk +73 lines, -0 lines 0 comments Download
A test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +277 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 8 months ago (2015-04-27 11:49:14 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
5 years, 8 months ago (2015-04-27 12:02:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110503002/1
5 years, 8 months ago (2015-04-27 12:13:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 12:15:36 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 12:15:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e82fbfbaf29e1862673795c10d634e1465bfb47
Cr-Commit-Position: refs/heads/master@{#28073}

Powered by Google App Engine
This is Rietveld 408576698