Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1110493002: ChromeOS Gaia: UI polishing (Closed)

Created:
5 years, 8 months ago by Roman Sorokin (ftl)
Modified:
5 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Gaia: UI polishing -Fixed Enterprise Enrollment window size -Added autocomplete option to the offline login -Added default domain "gmail.com" on offline login when user do not enter domain -gaia-core-icon-button does not have box-shadow when it is hovered BUG=480449, 479128, 478453, 478452 Committed: https://crrev.com/2d816075d4793faf9cbd1e396d9818b81f1e91ef Cr-Commit-Position: refs/heads/master@{#327043}

Patch Set 1 #

Patch Set 2 : Changed line-height for gaia-body-text #

Total comments: 2

Patch Set 3 : Rtl nit #

Patch Set 4 : Fixed copyright #

Messages

Total messages: 14 (6 generated)
Roman Sorokin (ftl)
Nikita, please review
5 years, 8 months ago (2015-04-27 09:51:43 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/1110493002/diff/20001/chrome/browser/resources/chromeos/login/gaia_input_form.css File chrome/browser/resources/chromeos/login/gaia_input_form.css (right): https://codereview.chromium.org/1110493002/diff/20001/chrome/browser/resources/chromeos/login/gaia_input_form.css#newcode36 chrome/browser/resources/chromeos/login/gaia_input_form.css:36: right: 0; nit: rtl?
5 years, 8 months ago (2015-04-27 12:56:16 UTC) #3
Roman Sorokin (ftl)
https://codereview.chromium.org/1110493002/diff/20001/chrome/browser/resources/chromeos/login/gaia_input_form.css File chrome/browser/resources/chromeos/login/gaia_input_form.css (right): https://codereview.chromium.org/1110493002/diff/20001/chrome/browser/resources/chromeos/login/gaia_input_form.css#newcode36 chrome/browser/resources/chromeos/login/gaia_input_form.css:36: right: 0; On 2015/04/27 12:56:16, Nikita Kostylev wrote: > ...
5 years, 8 months ago (2015-04-27 14:02:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110493002/40001
5 years, 8 months ago (2015-04-27 14:03:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59210)
5 years, 8 months ago (2015-04-27 14:09:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110493002/60001
5 years, 8 months ago (2015-04-27 14:13:50 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-27 14:42:59 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:44:20 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2d816075d4793faf9cbd1e396d9818b81f1e91ef
Cr-Commit-Position: refs/heads/master@{#327043}

Powered by Google App Engine
This is Rietveld 408576698