Cursor state should be global for desktop Aura

ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc

Index: ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
diff --git a/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc b/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
index eed97f32af54167d7e59bd1919331523bd15e62f..222e188ec19fd44c8fb2d9b8ae531ba2757d913a 100644
--- a/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
+++ b/ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc
@@ -11,13 +11,11 @@
 namespace views {
 
 DesktopNativeCursorManager::DesktopNativeCursorManager(
-    aura::RootWindow* window,
     scoped_ptr<DesktopCursorLoaderUpdater> cursor_loader_updater)
-    : root_window_(window),
-      cursor_loader_updater_(cursor_loader_updater.Pass()),
+    : cursor_loader_updater_(cursor_loader_updater.Pass()),
       cursor_loader_(ui::CursorLoader::Create()) {
   if (cursor_loader_updater_.get())
-    cursor_loader_updater_->OnCreate(root_window_, cursor_loader_.get());
+    cursor_loader_updater_->OnCreate(1.0f, cursor_loader_.get());
 }
 
 DesktopNativeCursorManager::~DesktopNativeCursorManager() {
@@ -29,6 +27,15 @@ gfx::NativeCursor DesktopNativeCursorManager::GetInitializedCursor(int type) {
   return cursor;
 }
 
+void DesktopNativeCursorManager::AddRootWindow(aura::RootWindow* root_window) {
+  root_windows_.insert(root_window);
+}
+
+void DesktopNativeCursorManager::RemoveRootWindow(
+    aura::RootWindow* root_window) {
+  root_windows_.erase(root_window);
+}
+
 void DesktopNativeCursorManager::SetDisplay(
     const gfx::Display& display,
     views::corewm::NativeCursorManagerDelegate* delegate) {
@@ -48,8 +55,14 @@ void DesktopNativeCursorManager::SetCursor(
   cursor_loader_->SetPlatformCursor(&new_cursor);
   delegate->CommitCursor(new_cursor);
 
-  if (delegate->GetCurrentVisibility())
-    root_window_->SetCursor(new_cursor);
+  if (delegate->GetCurrentVisibility()) {
+    RootWindows root_windows(root_windows_);
+    for (RootWindows::const_iterator i = root_windows.begin();
+         i != root_windows.end();
+         ++i) {
+      (*i)->SetCursor(new_cursor);
+    }
+  }
 }
 
 void DesktopNativeCursorManager::SetVisibility(
@@ -62,10 +75,20 @@ void DesktopNativeCursorManager::SetVisibility(
   } else {
     gfx::NativeCursor invisible_cursor(ui::kCursorNone);
     cursor_loader_->SetPlatformCursor(&invisible_cursor);
-    root_window_->SetCursor(invisible_cursor);
+    RootWindows root_windows(root_windows_);

[sky, 2013/12/13 16:56:44]

Do you really need to copy here and below?

[tdanderson, 2013/12/13 17:05:15]

Is your concern that I shouldn't need to copy at all, or that I should only be
copying once within this function and using the same copy for both loops?

[oshima, 2013/12/13 18:08:28]

I agree with sky. You shouldn't have to copy at all because the list won't
change during the call of this method.

+    for (RootWindows::const_iterator i = root_windows.begin();
+         i != root_windows.end();
+         ++i) {
+      (*i)->SetCursor(invisible_cursor);
+    }
   }
 
-  root_window_->OnCursorVisibilityChanged(visible);
+  RootWindows root_windows(root_windows_);
+  for (RootWindows::const_iterator i = root_windows.begin();
+       i != root_windows.end();
+       ++i) {
+    (*i)->OnCursorVisibilityChanged(visible);
+  }
 }
 
 void DesktopNativeCursorManager::SetCursorSet(
@@ -90,7 +113,12 @@ void DesktopNativeCursorManager::SetMouseEventsEnabled(
 
   SetVisibility(delegate->GetCurrentVisibility(), delegate);
 
-  root_window_->OnMouseEventsEnableStateChanged(enabled);
+  RootWindows root_windows(root_windows_);
+  for (RootWindows::const_iterator i = root_windows.begin();
+       i != root_windows.end();
+       ++i) {
+    (*i)->OnMouseEventsEnableStateChanged(enabled);
+  }
 }
 
 }  // namespace views