Issue 1110423002: Fix crash when rotating screen after resume

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110423002: Fix crash when rotating screen after resume (Closed)

Created:
5 years, 7 months ago by etiennej

Modified:
5 years, 6 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, blundell

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix crash when rotating screen after resume. This CL is dependent on http://crrev.com/1113473002. It fixes (partially) issue #99 (https://github.com/domokit/mojo/issues/99).

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

etiennej

The fix to the screen rotation crash, as discussed yesterday.

5 years, 7 months ago (2015-04-29 11:28:15 UTC) #2

jamesr

lgtm, but it's probably worth investigating why we need this changes when it appears chromium ...

5 years, 7 months ago (2015-04-30 00:11:21 UTC) #3

etiennej

5 years, 7 months ago (2015-04-30 12:27:08 UTC) #4

I am holding off on submitting this CL as I have
https://codereview.chromium.org/1110423002/ that also solves this bug, in
addition to not displaying a black screen on resume.

https://codereview.chromium.org/1110423002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1110423002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3632: // Destroy needs to be
called before the VertexAttribManagers are destoryed
On 2015/04/30 00:11:21, jamesr wrote:
> s/destoryed/destroyed/

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages