Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: Source/core/layout/LayoutBlockFlow.cpp

Issue 1110403002: [New Multicolumn] Disallow multicol on replaced content and fieldsets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/multicol/textarea-with-placeholder-as-multicol-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutBlockFlow.cpp
diff --git a/Source/core/layout/LayoutBlockFlow.cpp b/Source/core/layout/LayoutBlockFlow.cpp
index 914c9de5a4b3720e53bc7e6ecf988c4ed8f44ce5..516ee2fefb9999aa9fce21c9145c41c9d1e9a712 100644
--- a/Source/core/layout/LayoutBlockFlow.cpp
+++ b/Source/core/layout/LayoutBlockFlow.cpp
@@ -3100,6 +3100,15 @@ void LayoutBlockFlow::createOrDestroyMultiColumnFlowThreadIfNeeded(const Compute
if (isRuby())
return;
+ // Fieldsets look for a legend special child (layoutSpecialExcludedChild()). We currently only
+ // support one special child per layout object, and the flow thread would make for a second one.
+ if (isFieldset())
+ return;
+
+ // Form controls are replaced content, and are therefore not supposed to support multicol.
+ if (isFileUploadControl() || isTextControl() || isListBox())
+ return;
+
LayoutMultiColumnFlowThread* flowThread = createMultiColumnFlowThread(type);
addChild(flowThread);
« no previous file with comments | « LayoutTests/fast/multicol/textarea-with-placeholder-as-multicol-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698