|
[New Multicolumn] Disallow multicol on replaced content and fieldsets.
It's meaningless to multicol replaced content. For fieldsets it might make
sense, though, but currently we cannot, because the
layoutSpecialExcludedChild() mechanism only allows one special child per object
(the flow thread and the legend would make for two).
layoutSpecialExcludedChild() was especially bad for a TEXTAREA with a
placeholder attribute when attempting to multicol it, because we would go ahead
and lay out the placeholder (during TEXTAREA layout), which would be a child of
the flow thread. So we would lay out the grandchild before laying out its
parent, causing assertion failures in
LayoutMultiColumnFlowThread::columnSetAtBlockOffset().
BUG= 482362
R=dsinclair@chromium.org,jchaffraix@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194657
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+62 lines, -1 line) |
Patch |
|
M |
LayoutTests/TestExpectations
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/fieldset-as-multicol.html
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/fieldset-as-multicol-expected.html
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/file-upload-as-multicol.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/file-upload-as-multicol-expected.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/input-as-multicol.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/input-as-multicol-expected.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/listbox-as-multicol.html
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/listbox-as-multicol-expected.html
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/textarea-as-multicol.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
LayoutTests/fast/multicol/textarea-as-multicol-expected.html
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/fast/multicol/textarea-with-placeholder-as-multicol-crash.html
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/fast/multicol/textarea-with-placeholder-as-multicol-crash-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutBlockFlow.cpp
|
View
|
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|