Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: src/lookup.cc

Issue 1110393003: drop interalization of strings entering global constant slots (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index a9f24baf30e9509e5ddadd3969d7284c00804f24..809fd0eb2ef58a3bc292867135784c569b6bebdc 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -332,15 +332,15 @@ Handle<Object> LookupIterator::GetDataValue() const {
}
-Handle<Object> LookupIterator::WriteDataValue(Handle<Object> value) {
+void LookupIterator::WriteDataValue(Handle<Object> value) {
DCHECK_EQ(DATA, state_);
Handle<JSObject> holder = GetHolder<JSObject>();
if (holder_map_->is_dictionary_map()) {
Handle<NameDictionary> property_dictionary =
handle(holder->property_dictionary());
if (holder->IsGlobalObject()) {
- value = PropertyCell::UpdateCell(property_dictionary, dictionary_entry(),
- value, property_details_);
+ PropertyCell::UpdateCell(property_dictionary, dictionary_entry(), value,
+ property_details_);
} else {
property_dictionary->ValueAtPut(dictionary_entry(), *value);
}
@@ -349,7 +349,6 @@ Handle<Object> LookupIterator::WriteDataValue(Handle<Object> value) {
} else {
DCHECK_EQ(v8::internal::DATA_CONSTANT, property_details_.type());
}
- return value;
}
« no previous file with comments | « src/lookup.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698