Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Unified Diff: src/isolate.cc

Issue 1110393002: Disable stack trace preprocessing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix cctest.status Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index b548fb3870e25c46aee565353770d6a44b2512e0..f3596483112c00f8dbc2081c1a24bab75fae6c4e 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -410,11 +410,7 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSObject> error_object,
elements->Shrink(cursor);
Handle<JSArray> result = factory()->NewJSArrayWithElements(elements);
result->set_length(Smi::FromInt(cursor));
- // Queue this structured stack trace for preprocessing on GC.
- Handle<Object> old_weak_list(heap()->weak_stack_trace_list(), this);
- Handle<WeakFixedArray> new_weak_list =
- WeakFixedArray::Add(old_weak_list, elements);
- factory()->set_weak_stack_trace_list(new_weak_list);
+ // TODO(yangguo): Queue this structured stack trace for preprocessing on GC.
return result;
}
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698