Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1110393002: Disable stack trace preprocessing. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable stack trace preprocessing. This has to wait until issue 4065 has been fixed. R=ulan@chromium.org BUG=v8:2340, v8:4065, chromium:482312 LOG=N Committed: https://crrev.com/0327f8de2ea778e6bf26de908c937d340c687ec5 Cr-Commit-Position: refs/heads/master@{#28175}

Patch Set 1 #

Patch Set 2 : remove commented code #

Patch Set 3 : update test expectations #

Patch Set 4 : fix cctest.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/isolate.cc View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Yang
5 years, 7 months ago (2015-04-29 09:35:15 UTC) #1
ulan
lgtm
5 years, 7 months ago (2015-04-30 10:51:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110393002/20001
5 years, 7 months ago (2015-04-30 10:52:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/15)
5 years, 7 months ago (2015-04-30 11:07:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110393002/40001
5 years, 7 months ago (2015-04-30 12:38:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/27)
5 years, 7 months ago (2015-04-30 12:43:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110393002/60001
5 years, 7 months ago (2015-04-30 13:48:20 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-04-30 15:04:24 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 15:04:38 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0327f8de2ea778e6bf26de908c937d340c687ec5
Cr-Commit-Position: refs/heads/master@{#28175}

Powered by Google App Engine
This is Rietveld 408576698