Issue 1110333002: [chrome/browser/plugins] favor DCHECK_CURRENTLY_ON for better logs

Issue 1110333002: [chrome/browser/plugins] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 7 months ago by anujsharma

Modified:
5 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, jam, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/plugins BUG=466848 Committed: https://crrev.com/21861e6ab1b9c31d9ebbd487fb5c4e5a3afa7418 Cr-Commit-Position: refs/heads/master@{#327464}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	chrome/browser/plugins/chrome_plugin_service_filter.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/plugins/plugin_finder.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/plugins/plugin_prefs.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugins/plugin_status_pref_setter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/29 09:20:24, Bernhard Bauer wrote: > LGTM, thanks! Thanks Bernhard for lgtm.

5 years, 7 months ago (2015-04-29 09:21:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110333002/1

5 years, 7 months ago (2015-04-29 09:21:14 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 10:08:42 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/21861e6ab1b9c31d9ebbd487fb5c4e5a3afa7418
Cr-Commit-Position: refs/heads/master@{#327464}