content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 1110323005: Expose SW accesses in "Cookies set by this page" UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 1110323005: Expose SW accesses in "Cookies set by this page" UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index ac27aa3a859b33e3ba650aa74c08d0dc56a4af87..e2e598034acc33a8cf1958ddfa9fd244dd02943f 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -183,9 +183,9 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(

DCHECK(registration.get());

if (!GetContentClient()->browser()->AllowServiceWorker(

- registration->pattern(),

- provider_host_->topmost_frame_url(),

- resource_context_)) {

+ registration->pattern(), provider_host_->topmost_frame_url(),

+ resource_context_, provider_host_->process_id(),

+ provider_host_->frame_id())) {

job_->FallbackToNetwork();

TRACE_EVENT_ASYNC_END2(

"ServiceWorker",